Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Broker Data Plane Conformance tests for the Ingress and Consumer #3531

Merged
merged 5 commits into from
Jul 21, 2020
Merged

Add Broker Data Plane Conformance tests for the Ingress and Consumer #3531

merged 5 commits into from
Jul 21, 2020

Conversation

lberk
Copy link
Member

@lberk lberk commented Jul 7, 2020 •
edited
Loading

Adding Data plane conformance tests for ingress and consumer as reported in #2705

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 7, 2020
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 7, 2020
@knative-prow-robot knative-prow-robot added the area/test-and-release Test infrastructure, tests or release label Jul 7, 2020
@vaikas vaikas mentioned this pull request Jul 16, 2020
Merged
@lberk lberk force-pushed the broker-data-plane-tests branch from 8a0b895 to 3ef4e95 Compare July 20, 2020 17:07
mattmoor
mattmoor reviewed Jul 20, 2020
View reviewed changes
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Produced via:
gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -name '*.pb.go' -prune -o -type f -name '*.go' -print)
goimports -w $(find -name '*.go' | grep -v vendor | grep -v third_party | grep -v .pb.go | grep -v wire_gen.go)

n3wscott
n3wscott reviewed Jul 20, 2020
View reviewed changes
Copy link
Contributor

@n3wscott n3wscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Want to follow up with the same tests for broker v1? :D

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 20, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lberk, n3wscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 20, 2020
@lberk
Copy link
Member Author

lberk commented Jul 20, 2020

/lgtm
/approve

Want to follow up with the same tests for broker v1? :D

absolutely! thanks!

@n3wscott
Copy link
Contributor

/retry

@pierDipi
Copy link
Member

/retest

@knative-test-reporter-robot
Copy link

The following jobs failed:

Test name Triggers Retries
pull-knative-eventing-integration-tests 2020-07-21 06:19:00.719 +0000 UTC 1/3

Automatically retrying due to test flakiness...
/test pull-knative-eventing-integration-tests

@knative-prow-robot knative-prow-robot merged commit 46a7cdb into knative:master Jul 21, 2020
@vaikas
Copy link
Contributor

vaikas commented Jul 21, 2020

Sorry for being late to the party (timezone diff and all :) ). Thanks for doing this, looks great!!! I'll file an issue for documentating how to run these tests for pre-existing brokers without having to look at the code :)

@vaikas vaikas mentioned this pull request Jul 21, 2020
Closed
@lberk lberk mentioned this pull request Aug 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattmoor mattmoor mattmoor left review comments

@vaikas vaikas vaikas left review comments

@n3wscott n3wscott n3wscott left review comments

@chaodaiG chaodaiG Awaiting requested review from chaodaiG

@yt3liu yt3liu Awaiting requested review from yt3liu

Assignees

@n3wscott n3wscott

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@lberk @knative-prow-robot @n3wscott @pierDipi @knative-test-reporter-robot @vaikas @mattmoor @googlebot